List of Completed Fixes and Features

Todo List

Things to Note

  1. Problem in STrees library with alias of split. Now called splitPath
         > h["*btn"] = Widget("a","XmLabel",realize=F)
         Warning messages:
           Conflicting definitions of function "split" on databases
         	     "/home/duncan/RESEARCH/GUI/SXLib/STrees" and "main" in: XPath(obj)
          
  2. draw-start.s example skipping connection numbers by 1 so somebody is opening a display behind our back. Although we are opening the image file. But is this not getting closed somewhere!
    ChangeGC setting color values from strings (e.g. Foreground="red") is opening display. That is fixed (by changing the class to XPixel rather than XColor) but file descriptor jump of two is still present. Seems to be in the Image Pixmap. Actually, it is just GIF files. The problem was that the loop at the end of readGIF would be executed if there was no error and at the end just return without closing the file descriptor.
  3. Look further into the Color model.
    Done that. What we want is to Convert XColor to Pixel! and have XColor extend the class XPixel.
  4. Fix the XGC.S coerce method for logical to XGCGraphicsExposures for NamedLogical using the to argument when that coerce code is fixed here.
    Not needed anymore as we removed that class and just used a NamedLogical, I think.
  5. Remove all the XGCPlaneMask class related material.
  6. LineStyle doesn't work as an integer. Getting passed to the process_gc_args, but just not working.
  7. CHECK Fix process_gc_args to use INTEGER_VALUE rather than the AS_INTEGER ->value.Long[0].
    Check this. Changed the code.
  8. Seems to be gone now
          XLines(x0,x0,X@widget,gc,GraphicsExposures=F,LineWidth=3,Foreground="red")
          Warning messages:
             Invalid display in: character.toColor(val, to = "XColor",
          disp = display)
          
  9. Remove all the XGCGraphicsExposures class related material. Gone from the code, not from the files.
  10. Method for XApplication that takes an XApplication description.
  11. getResource is very slow!
    Use CompilableXResource objects.
  12. Datbase not getting the dpy.info from XDisplay method.
  13. database isn't getting dpy.info slot set in XDatabase for XAppDisplay!
  14. Check are we calling XtAppInitialize more than once and is that giving us back the same display etc.
    I don't think so.
  15. Sme and SmeBSB "widgets" in the Xaw and Xaw3D widget sets should not be created as they cause segmentation faults. Remove these when we find out more about them and why they are present. They are windowless objects so life is complicated. Similar to gadgets but more annoying.
  16. Dialogs now can be managed and unmanaged. Create them unmanaged and them manage them to pop them up and unmanage them to pop them down.
  17. If you just want a dialog, you need an application. We want to have a standard S application such as a toolbar that we can use for common tasks, but also as a known XApplication object sitting in the session frame somewhere or as a particular task.
  18. Can't make the XDatabase class virtual as we coerce objects to that class since they have a common representation.
    Don't need to. Reorganized the classes Date: Sun Mar 30 08:15 PST 97
  19. getResource if fails can still return the value for the previous resource
      getResource(btn,"labelString","background","armCallback")
      [[1]]:
      [1] "labelString: Duncan Temple Lang"
       
      [[2]]:
      [1] "background: 29951"
       
      [[3]]:
      [1] "armCallback: 29951"
       
      Warning: No type converter registered for 'Callback' to 'SObject' conversion.
      Warning: Type conversion (Callback to SObject) failed for widget 'btn'
          
  20. Cleanup XResource retrieval with respect to the return type. Make the internals decide what is the best type to return if user doesn't specify a value.
  21. opening an XDisplay without an application context - dangerous if used incorrectly? Use XAppDisplay class! Make XApplication, etc. use this. Can't use a display to create a shell unless it is a Display opened as part of an XApplication.
  22. Don't use Calloc to allocate an object which will be inserted into a "raw" object unless the space is allocated in a PERM_FRAME. If this is done, the object disappears an all sorts of interesting things could happen. set_alloc();
  23. Backing store for Drawing Widgets should be an option. See backingStore()
  24. XTextWidth in SXDraw.S doesn't work
        Problem in XTextWidth("Hi there", gc = gc): Error on display :0.0 (file
        	    descriptor 15)
        X Message: BadFont (invalid Font parameter)
        Debug ? (y|n): n
          
  25. Made the drawing primitives convert to integers using 'floor()' before calling C routines. Also, C routines now coerce to integer also using AS_INTEGER. Double overkill! If NAs are generated, anything can happen but X will protect us as the resulting integer is typically outside of the clipping region! But if things go wrong, this is a good place to start checking.
    Repetition of arguments to ensure equal length is done in S by cbind, etc.
  26. Fix GC.args to handle ... and all the arguments and then fix XLines back to call the correct form.
  27.       > ChangeGC(gc,Font = fid)
          Warning messages:
            Old-style internal form of argument "", maybe from data.restore() in: GC.args(\
    	args, dflt)
    
  28. ... arguments for drawing routines broken! Maybe not. Think I fixed it. Date: Wed Mar 19 12:25 PST 97
  29. Bug in rectangles - number of rectangles plotted is incorrect. Just two.
          
           XRectangles(c(100,200,300,400),c(100,200,300,400),c(20,40),c(20,40),draw,gc)
           [1] 4
    

    Same with XArcs. Doesn't handle vector arguments correctly.
    THis is is not a bug, just the fact that the plots were outside the clipping region.
  30. Get the pixels in sub-regions of a drawable. GetPixels() and GetPixelValues().
    Should fix this to use XGetSubImage and XCreateImage. This requires visuals, etc.
  31. Return type for getXDrawableDisplay or whatever to identify the class that was found.
  32. Machine specific constants from X. Write C apps to generate these at installation.
    Look in SXLib/Install/ and there are executables there that do this. Currently, this works for cursors and GC slot values (e.g LineStyles, etc.)
  33. GC.args seems to be broken - Mmm! Fixed. Don't copy the names of the args to the vals as they are out of order and the class types for the converters are completely wrong.
  34. Fix the Pixmap.file - necessity.
    If dimensions are missing, then we know that the string is a file!
  35. If you do an AS_... shouldn't you have COPYed or REPLACEd the object.
  36. CHANGE ALL THE EXAMPLES TO USE THE NEW NAMES FOR THE WIDGETS!
  37. Can Widget, etc. actually extend a common ancestor class XDrawable. No, but we have set the classes now. The value slot needs to be raw for a widget and numeric for a real drawbable since it is an ID resource.

Duncan Temple Lang<duncan@stat.Berkeley.EDU>
Last modified: Fri Apr 4 11:10:04 PST 1997